Mine is probably Sekiro. I really dislike the story being about feudal Japan and the main character being the grunt for a privileged asshole but the combat and bosses are so good. I don’t think any game will ever top that.
To see how good the game is, compare it to J*di Knight: Fallen Order, which is essentially meant to be a clone of Sekiro but is so lacklustre in comparison.
I can’t probably say exactly which is my all time favorite but i loved Age Of Empire 3 , Spore , Warcraft 3 and Minecraft when i was younger and I now I also really liked Fallout 4 , Skyrim and the game that I play the most these time is World Of Tank , its an horrible game , hard , grindy , not so fun but its nice to play.
Dang I forgot about age of empires, I miss those a lot.