I had no idea this issue had been identified. While I find this tool very useful, the project is seeming rather questionable to me now.

  • ⸻ Ban DHMO 🇦🇺 ⸻@aussie.zone
    link
    fedilink
    English
    arrow-up
    14
    arrow-down
    12
    ·
    20 hours ago

    I haven’t read to far into this but the issue is completely devoid of contributors and maintainers. I find the wording of the issue quite concerning:

    Due to the recent XZ-Utils drama I checked the code and I’m appalled. There are more BLOBS than source code. https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/cryptsetup https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/Unix/ventoy_unix https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/DMSETUP

    There is no reason to have those not be build in the release process. Of course it’s convenient, they are prebuild, it’s fast and nobody has a problem with it.

    Recent events however showed that these BLOBs can contain everything and nothing. The build instructions would not produce the exact same executable for everyone. It’s better to have GitHub build it on-push and use them out of the build cache.

    I would do it myself, but unfortunately I’m not familiar enough with the Ventoy build process to actually do it. I understand that removing BLOBs isn’t a priority over new and shiny features. But due to recent events, this should be rethought.

    Thank you for reading this and I hope for a productive conversation

    This is free software, they don’t owe you anything and this kind of language sounds angry and entitled. You can’t just Gordon Ramsay on someone else’s codebase.

    • interdimensionalmeme@lemmy.ml
      link
      fedilink
      arrow-up
      2
      ·
      3 hours ago

      Actually you can and should Gordon Ramsey all over it. It is the duty of audience members to express how they feel honestly about the artwork.

      Open Source can and do understand that and open source software becomes better for it.

    • bleistift2@sopuli.xyz
      link
      fedilink
      English
      arrow-up
      5
      ·
      5 hours ago

      I cannot fathom what in this issue description gives rise to your concern. It’s worded very calmly, clearly explaining why the author thinks these BLOBs shouldn’t be there, expressing an understanding that it’s not a top priority and even closing with a thank you.

      • ⸻ Ban DHMO 🇦🇺 ⸻@aussie.zone
        link
        fedilink
        English
        arrow-up
        1
        arrow-down
        1
        ·
        edit-2
        2 hours ago

        Is this not rude:

        I checked the code and I’m appalled. There are more BLOBs than source code

        And this:

        I understand that removing BLOBs isn’t a priority over new and shiny features. But due to recent events, this should be rethought.

        We didn’t like it when MS made an issue trying to direct ffmpeg

        They should have opened with a complement or asked for directions if they didn’t know. In this message “Thank You” means fuck all

    • Wave@lemmy.ml
      link
      fedilink
      English
      arrow-up
      9
      ·
      13 hours ago

      I mean, people are allowed to have opinions. They may not be good opinions but thats the glory of opinions. You can Gordon Ramsey someone’s codebase, and someone else can Gordon Ramsey their comment, as you just did.

    • lorty@lemmy.ml
      cake
      link
      fedilink
      arrow-up
      2
      ·
      11 hours ago

      I mean the author has simply ignored this issue. If you look into it there are a few that people simply do not know how to generate, so without the maintainer it’s impossible to make a PR solving this.

      • ⸻ Ban DHMO 🇦🇺 ⸻@aussie.zone
        link
        fedilink
        English
        arrow-up
        2
        arrow-down
        6
        ·
        10 hours ago

        I mean if I got an issue that sounded that entitled and this is something I do in my spare time, I’d probably ignore it.

        My point is they could have worded it better and it might have gotten a response. If you ask kindly about the BLOBs and maybe for some help to push you in the right direction instead of saying “I don’t know”, then it is fair to call the maintainer rude for ignoring it completely.

  • Todd Bonzalez@lemm.ee
    link
    fedilink
    arrow-up
    33
    arrow-down
    11
    ·
    1 day ago

    Anyone who wants to fix this can help fix it, but people are just making demands of an unpaid maintainer. The devs can run this project the way they want to. If you don’t like it, don’t use Ventoy.

    The people comparing this to the xz exploit are out of line. xz was a library that was deeply embedded in a lot of software. Ventoy is an IT tool used to boot live OSes. Not even remotely the same attack surface.

    Blobs in the source tree are not ideal, but people need to pick their battles.

    • Lemongrab@lemmy.one
      link
      fedilink
      arrow-up
      44
      arrow-down
      1
      ·
      1 day ago

      From what others have said: The blobs violate GPL because they are taken from other FOSS project but the changes Ventoy makes are not viewable.

    • tetris11@lemmy.ml
      link
      fedilink
      arrow-up
      6
      ·
      1 day ago

      Little did they know that Patches the Cat bit through their LAN lines and actually increased the cost of their communication.

  • Antagnostic@lemmy.world
    link
    fedilink
    arrow-up
    195
    arrow-down
    1
    ·
    edit-2
    2 days ago

    I was bored at work one day. I decided to put a nyan cat easter egg in my company’s app. If at the loading progress bar screen you typed NYAN it would turn the progress bar into a rainbow being created by a little nyan cat while playing the nyan cat song. The mp3 (inconspicuously renamed without the extension) doubled our build size. No one batted an eye cause no one paid attention to the build size much.

    Fast forward 5 years later, at a different job, I get a phone call from the old boss. Do you happen to know anything about this nyan cat file we found?

    I had no idea what he was talking about.

    • fmstrat@lemmy.nowsci.com
      link
      fedilink
      English
      arrow-up
      55
      ·
      2 days ago

      Years and years ago I worked on a project where the logo was the outline of a head and an inward swirl for the brain.

      For the website, if you held your mouse over it for 9 seconds, it would spin and flush. No one ever found that one that I know of.

      • kautau@lemmy.world
        link
        fedilink
        arrow-up
        7
        ·
        2 days ago

        It sounds like they weren’t using any form of version control, so that’s definitely on them at this point

        • Alexstarfire@lemmy.world
          link
          fedilink
          arrow-up
          13
          ·
          2 days ago

          What makes you say that? To me, it sounds like that’s what they do have cause they tracked the change back to him. The commit message obviously said nothing about the file.

          • kautau@lemmy.world
            link
            fedilink
            arrow-up
            3
            ·
            1 day ago

            Ah I could see that. I took it as them not knowing where the file came from at all, so they’re just asking all the devs who would have had access at that point, which is why it was “hey do you know anything about this file?” and not “is there a specific reason you committed this file to the build?”

              • kautau@lemmy.world
                link
                fedilink
                arrow-up
                1
                ·
                3 hours ago

                You think they’d call up devs who left them just to ask if they happen to know about a random file?

                I mean, that’s what op said happened. Literally with the verbiage of “file we found” and not “file you committed”

  • Mikelius@lemmy.ml
    link
    fedilink
    arrow-up
    44
    arrow-down
    3
    ·
    2 days ago

    Glad it’s getting a little more light. Been trying to tell people this for a few years now lol. It’s the reason I’ve stayed away from it since first learning of the tool and looking at the “source code”.

  • n2burns@lemmy.ca
    link
    fedilink
    arrow-up
    79
    arrow-down
    3
    ·
    2 days ago

    I too wish the developer would respond, but I don’t think this is the catastrophe people are making it out to be. One comment seems to explain why these binaries are included:

    Because ventoy supports shim, and by extension secure boot, these files needs to come from a signed Linux distro. In this case they are taken from Fedora releases, and OpenSUSE apparently, as they publish shim binaries and grub binaries signed by their certificate.

      • Quail4789@lemmy.ml
        link
        fedilink
        English
        arrow-up
        22
        arrow-down
        3
        ·
        2 days ago

        It matters because nobody is going to check the hashes for all of the files match whenever there’s a change so the maintainer can just replace them with whatever he wants.

        • Pup Biru@aussie.zone
          link
          fedilink
          English
          arrow-up
          20
          ·
          2 days ago

          that’s what automation is for - nobody is going to manually check them, but anyone is able to automatically set something up to check their hashes in change… the fact that it’s possible that anyone is doing that now that it’s a known issue perhaps makes it less problematic as an attack vector

          • refalo@programming.dev
            link
            fedilink
            arrow-up
            3
            arrow-down
            1
            ·
            24 hours ago

            That is true, but also nobody is doing it. Just like nobody is verifying Signal’s “reproducible builds”.

            • Pup Biru@aussie.zone
              link
              fedilink
              English
              arrow-up
              3
              ·
              16 hours ago

              are you sure?

              there could be thousands just waiting for a failure to come out and say “HEY THIS IS DODGY”

              • refalo@programming.dev
                link
                fedilink
                arrow-up
                1
                ·
                edit-2
                12 hours ago

                Yea because I tested it myself. Nobody else seems to care, and if they did, I would think there would be a public way to see regular test results regardless.

                I know this exists for some projects, but somehow nothing privacy-sensitive

          • Quail4789@lemmy.ml
            link
            fedilink
            English
            arrow-up
            13
            arrow-down
            1
            ·
            edit-2
            2 days ago

            The amount of malware you can cram in a source-code patch without drawing attention vs. in a binary is vastly different.

            There’s also the fact that if you want to ship binaries, you can just wget them from source during the build process. Not a perfect solution but much better than what’s ventoy doing. The source code updates works the same in every project because it has to. That’s why this is drawing more attention.

            • Ferk@lemmy.ml
              link
              fedilink
              arrow-up
              3
              ·
              edit-2
              1 day ago

              That’s ok if we are talking about malware publicly shown in the published source code… but there’s also the possibility of a private source-code patch with malware that it’s secretly being applied when building the binaries for distribution. Having clean source code in the repo is not a guarantee that the source code is the same that was used to produce the binaries.

              This is why it’s important for builds to be reproducible, any third party should be able to build their own binary from clean source code and be able to obtain the exact same binary with the same hash. If the hashes match, then you have a proof of the binary being clean. You have this same problem with every single binary distribution, even the ones that don’t include pre-compiled binaries in their repo.

              • refalo@programming.dev
                link
                fedilink
                arrow-up
                1
                ·
                12 hours ago

                The problem is not near enough projects support reproducible builds, and many that do aren’t being regularly verified, at least publicly.

    • grue@lemmy.world
      link
      fedilink
      English
      arrow-up
      30
      arrow-down
      7
      ·
      2 days ago

      On the contrary: that just goes to show what a fucking catastrophe for software freedom “Secure[sic] Boot” is.

    • nialv7@lemmy.world
      link
      fedilink
      arrow-up
      15
      ·
      2 days ago

      While this is true, it only requires the shim and grub to be copied for another distro.

      From other comments there are a lot more blobs than just these two.

    • infeeeee@lemm.ee
      link
      fedilink
      arrow-up
      10
      arrow-down
      1
      ·
      2 days ago

      It sounds to me as a documentation issue, as the next comment says, simply including a wget script should solve this.

  • PowerCrazy@lemmy.ml
    link
    fedilink
    English
    arrow-up
    69
    arrow-down
    13
    ·
    2 days ago

    Hey guys open source is great you can look at all the code and therefore there are no security backdoors etc. Also here are a bunch of pre-compiled blobs in the repo, don’t worry about those, but they are required to run the program.

  • monovergent@lemmy.ml
    link
    fedilink
    arrow-up
    29
    ·
    2 days ago

    Makes me wonder how far the closest alternative, glim, could be upgraded to match Ventoy given the confines of GRUB.

    Someone had mentioned that Fedora fails to verify when booting from Ventoy. Now I’m thinking if I could dd the media loaded via Ventoy and compare with an original copy to see what changed.

  • ulterno@lemmy.kde.social
    link
    fedilink
    English
    arrow-up
    7
    ·
    2 days ago

    I like multiboot. Used it back when I used Windows.
    The Ventoy advertisements on Reddit looked too suspicious, so I never checked it out.

  • LalSalaamComrade@lemmy.ml
    link
    fedilink
    English
    arrow-up
    27
    arrow-down
    1
    ·
    2 days ago

    Thank you for sharing this. I remember using Ventoy quite often back when I was still on Windows. I’ll be sticking with the good old dd command.

  • BrianTheeBiscuiteer@lemmy.world
    link
    fedilink
    arrow-up
    21
    arrow-down
    1
    ·
    2 days ago

    Any alternatives to this tool? I’ve used it a lot lately because I was testing out live OSes before installing one to the hard drive, but otherwise I don’t need it on a daily basis.

    • Snot Flickerman@lemmy.blahaj.zone
      link
      fedilink
      English
      arrow-up
      23
      arrow-down
      1
      ·
      2 days ago

      but otherwise I don’t need it on a daily basis.

      I’ll be real, this is part of why I didn’t understand Ventoy. I keep a bunch of large, fast thumbdrives around blank and available. When I need/want to put an OS on there, I do it when I need it, and then I’m always installing the most current version of the install. It takes under 5 minutes, at best.

      I used to try to keep various installs on thumbdrives… but it would be two years down the line by the time I needed to use it again and by that time it’s literally pointless to be using two year old installation media.

      • CoopaLoopa@lemmy.dbzer0.com
        link
        fedilink
        arrow-up
        19
        arrow-down
        1
        ·
        2 days ago

        Part of the point behind Ventoy is that you don’t need to prepare the USB to be bootable. You can just copy/paste the whole iso into Ventoy and it will be bootable. New release comes out? Just copy it onto your USB drive. Don’t even need to remove the old version of you don’t want to.

        Makes things much easier in the tech world for having a single USB with 50+ bootable tools and installers on there like with MediCat (which uses Ventoy as a base).

        Only thing I’ve had issues with booting from Ventoy is the ProxMox install iso. Everything else has worked first try.

      • BrianTheeBiscuiteer@lemmy.world
        link
        fedilink
        arrow-up
        13
        arrow-down
        2
        ·
        2 days ago

        Ventoy wasn’t a foolproof solution but it really did beat the hell out of using 6 different USB drives. Most USB “pen drives” don’t make labeling easy and without labeling I’m just plugging them in one by one till I find the one I want.

        • mbirth@lemmy.ml
          link
          fedilink
          English
          arrow-up
          3
          ·
          2 days ago

          I remember various different concepts of USB flash drives with integrated LCDs that would display a label and the remaining capacity. Then they vanished and the only thing left were the Lexar Echo drives. Until a few years ago, when they have been pulled from the markets. Probably, because they didn’t work with the now default GPT and its many different partition types.

      • TheGalacticVoid@lemm.ee
        link
        fedilink
        arrow-up
        2
        ·
        2 days ago

        As someone with few USBs available, Ventoy takes me 2 minutes to flash, several minutes to copy a set of ISOs, and then any time I need it, it takes 0 minutes to have a working USB with some arbitrary ISO. Sure, it’s not up to date, but I don’t need it to be if I need to recover an install or use some random tool.

      • thejevans@lemmy.ml
        link
        fedilink
        arrow-up
        6
        arrow-down
        2
        ·
        2 days ago

        When I was working in IT, this would have been a very useful tool for doing some on-site troubleshooting with various tools or for one-off reimaging machines that were missed during a big update or something. Instead, I had a bag of USB sticks with labels on them, which was annoying to use and to maintain.

  • MigratingtoLemmy@lemmy.world
    link
    fedilink
    English
    arrow-up
    13
    arrow-down
    1
    ·
    edit-2
    1 day ago

    Need to compare hashes between a stock ISO and one flashed booted by Ventoy (dd the latter to a file and check)