Pinching the screen (especially with single hand) doesn’t reliably zoom images and I have to try multiple times to get it to work
Pinching the screen (especially with single hand) doesn’t reliably zoom images and I have to try multiple times to get it to work
Nope, I have the same issue, but I have narrowed down the exact behavior.
If you put 2 fingers on the screen in a fullscreen image and slide them even the tiniest millimeter it will go into “pan mode” or so instead of zooming mode. You can no longer zoom until you release your fingers and place them without moving them at all before you pinch to zoom. (I have this happen much more often in practice while using the phone 1 handed on an unstable environment like a tram or train.
Interestingly, you can pan and zoom at the same time if already zoomed in, but on a full image where panning doesn’t do anything, it will lock both actions until you release your fingers.
I can confirm this exact behaviour.
Which device do you use
OnePlus 5T with LineageOS 20/Android 13
Could you test if you can still reproduce it in these builds (I can not test it myself as I can not seem to reproduce it)
I have modified some code to isolate the problem.
Release version of 46
Depending on how you installed it might not allow you to install this release version
Note replacing an existing install with this version, will probably delete your app info (it should tell you) use debug version instead if that is not wanted app-release_zoomable.zip
Debug version of 46 app-debug_zoomable.zip
This build seems to fix this issue! Sorry, that I didn’t test it sooner.
np
Can you also test if the problem is still fixed with this build and that the flick to exit works in the ImageViewer
https://github.com/dessalines/jerboa/files/12618555/fix_zooming_jerboa_debug.zip
It’s pretty much back to the behavior explained above. If you slightly move your fingers before zooming in, you are stuck at flicking the image away and can’t zoom.
Alright we will be dropping this feature until we make a proper swipe to exit
It’s hard to reproduce because it is not consistent but I see what you mean. Could you link the exact image that you managed to reproduce this. I’ll see if I can report this to the image library that we use.
https://feddit.de/pictrs/image/751bb5db-6c4b-499a-87c4-4fb51d013eb4.jpeg
Could you test if you can still reproduce it in these builds?
I have modified some code to isolate the problem.
Release version of 46
Depending on how you installed it might not allow you to install this release version
Note replacing an existing install with this version, will probably delete your app info (it should tell you) use debug version instead if that is not wanted app-release_zoomable.zip
Debug version of 46 app-debug_zoomable.zip
This does fix the issue for me
Can you also test if the problem is still fixed with this build and that the flick to exit works in the ImageViewer
https://github.com/dessalines/jerboa/files/12618555/fix_zooming_jerboa_debug.zip
It’s not, as soon as the image moves vertically I can’t zoom in anymore and it is easy to accidentally make it move before pinching. I think the image shouldn’t respond to vertical swipes with two fingers at all and should have a small dead zone for single finger swipes. That’s how WhatsApp seems to do it
Also the black background takes too long to disappear after a flick, it could be nicer if it faded away
There is a release 46 on f-droid. This does not fix the issue (tested on a few photos including this https://i.redd.it/mm6682q8tgmb1.jpg and this https://i.imgur.com/XRKZAhR.jpeg)
Perhaps it is an issue with embedding from reddit images?
If you still want me to, I cab probably install the debug version and attempt further debugging.
The release on Fdroid does not contain these experimental changes.
Only the above builds
Hm, I just tried it and it indeed does behave like you described, but only if you slide the fingers diagonally. If you slide them vertically you won’t have this issue and it’s the reason I didn’t stumble upon it before
Edit: wait, seems like this is not the case. It behaves weirdly, sometimes I can zoom just fine, sometimes sliding fingers won’t zoom but do nothing.
Also can you do this too:
Could you test if you can still reproduce it in these builds (I can not test it myself as I can not seem to reproduce it)
I have modified some code to isolate the problem.
Release version of 46
Depending on how you installed it might not allow you to install this release version
Note replacing an existing install with this version, will probably delete your app info (it should tell you) use debug version instead if that is not wanted app-release_zoomable.zip
Debug version of 46 app-debug_zoomable.zip
Which device do you use?
Which device do you use? It might be device specific. Hard to reproduce for me