• Pyro@lemmy.world
    link
    fedilink
    English
    arrow-up
    17
    ·
    10 months ago

    While I agree with the premise of the article, the code is completely unreadable to me. I took a look at the first snippet and just thought “Nah.”

    • vzq@lemmy.blahaj.zone
      link
      fedilink
      arrow-up
      1
      arrow-down
      1
      ·
      10 months ago

      That’s because it’s not the source. It’s not the preferred way of modifying the program. The state diagram is the preferred way of modifying the program.

    • NostraDavid@programming.dev
      link
      fedilink
      arrow-up
      3
      arrow-down
      7
      ·
      10 months ago

      You really need to know C to be able to read that code - If I only knew Python or Java I’d be hella lost too.

      • Pyro@lemmy.world
        link
        fedilink
        English
        arrow-up
        16
        ·
        10 months ago

        It’s not even that. I can generally read a C-like language, but when the first line I see is a long-ass array of bytes with zero documentation it just makes me not want to even try.

  • Redkey@programming.dev
    link
    fedilink
    arrow-up
    12
    ·
    edit-2
    10 months ago

    I love low-level stuff and this still took me a little while to break down, so I’d like to share some notes on the author’s code snippet that might help someone else.

    The function morse_decode is meant to be called iteratively by another routine, once per morse “character” c (dot, dash, or null) in a stream, while feeding its own output back into it as state. As long as the function returns a negative value, that value represents the next state of the machine, and the morse stream hasn’t yet been resolved into an output symbol. When the return value is positive, that represents the decoded letter, and the next call to morse_decode should use a state of 0. If the return value is 0, something has gone wrong with the decoding.

    state is just a negated index into the array t, which is actually two arrays squeezed into one. The first 64 bytes are a binary heap of bytes in the format nnnnnnlr, each corresponding to one node in the morse code trie. l and r are single bits that represent the existence of a left or right child of the current node (i.e. reading a dot or dash in the current state leading to another valid state). nnnnnn is a 6-bit value that, when shifted appropriately and added to 63, becomes an index into the second part of the array, which is a list of UTF-8/ASCII codes for letters and numbers for the final output.